feat: cleanup old model revision files #238
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polomani
reviewed
Mar 5, 2025
| { | ||
| _logger.LogInformation("Deleting expired model file: {FilePath}", revision.FilePath); | ||
| StateUtils.DeleteFileAndDirectory(revision.FilePath, revision.IsInDirectory); | ||
| revision.IsDeleted = true; |
There was a problem hiding this comment.
why are you not deleting the entry from the state entirely? it would make the code much simpler
There was a problem hiding this comment.
talked, figured that there will be issues in that case as well:
- once the model is removed from the state and the new run happens it would be downloaded to the temporary storage only (and removed after)
- to fix this properly we need to make the temp models be committed back to the main state after the use
polomani
reviewed
Mar 5, 2025
Comment on lines
+250
to
+254
| if(model.IsDeleted){ | ||
| var downloaded = await DownloadFileAsync(model, true).ConfigureAwait(false); | ||
| if(downloaded){ | ||
| model.IsDeleted = false; | ||
| } |
There was a problem hiding this comment.
if you remove the revision from the state (instead of only deleting the file) you should not need this
polomani
reviewed
Mar 5, 2025
Comment on lines
+270
to
+274
| var revisions = _state.Values | ||
| .Where(s => s.IsInDirectory | ||
| && !string.IsNullOrEmpty(s.FilePath) | ||
| && s.LastAccessTime.AddDays(_config.FilesTTL) < _dateTimeProvider.UtcNow) | ||
| .OrderByDescending(s => s.CreatedTime); |
There was a problem hiding this comment.
Multiple revisions can reuse one file, so this is unsafe.
also, removing the latest revision for the model is most likely not a good idea.
this code from VerifyLocalModelState could be taken as an example (or reused?)
var filesInUseMap = _state.Values
.Where(f => !string.IsNullOrEmpty(f.FilePath))
.ToDictionarySafe(f => f.FilePath, f => true);
if (statesToDelete.Any())
{
_logger.LogWarning("Removing {Num} model versions not found in CDF: {Versions}",
statesToDelete.Count,
string.Join(", ", statesToDelete.Select(s => s.ModelExternalId + " v" + s.Version)));
var statesToDeleteWithFile = statesToDelete
.Select(s => (s, !filesInUseMap.ContainsKey(s.FilePath)));
await _store
.RemoveFileStates(_config.FilesTable, statesToDeleteWithFile, token)
.ConfigureAwait(false);
}
polomani
reviewed
Mar 5, 2025
| @@ -196,6 +200,7 @@ await _store.RestoreExtractionState<U, T>( | |||
| HashSet<string> idsToKeep = new HashSet<string>(_state.Select(s => s.Value.Id)); | |||
| ldbStore.RemoveUnusedState(_config.FilesTable, idsToKeep); | |||
| } | |||
| CleanExpiredModelRevisionFiles(); | |||
There was a problem hiding this comment.
only on restart? this may never happen if the connector is stable enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new property,
LastAccessTime, in the local state for simulator model revisions. Each time a revision is accessed, this property will be updated. Based on theFilesTTLvalue defined in theconfig.yaml, it will check whether the last usage of a file exceeds the specified retention period. If the file has not been accessed within the defined timeframe, it will be deleted.