feat: add license controller + process termination support #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 71.83% 72.87% +1.04%
==========================================
Files 33 35 +2
Lines 3554 3742 +188
Branches 422 437 +15
==========================================
+ Hits 2553 2727 +174
- Misses 844 854 +10
- Partials 157 161 +4
🚀 New features to boost your workflow:
|
abdullah-cognite
changed the title
polomani
reviewed
Mar 6, 2025
abdullah-cognite
changed the title
polomani
approved these changes
Mar 6, 2025
abdullah-cognite
commented
Mar 6, 2025
| } | ||
| } | ||
| if (!found) { | ||
| throw new Exception("No processes found to kill for the current user"); |
There was a problem hiding this comment.
Refactor this into a separate unsafe method
There was a problem hiding this comment.
can be done in a separate pr as well
abdullah-cognite
commented
Mar 6, 2025
| { | ||
| foreach (ManagementObject process in results) | ||
| { | ||
| try |
There was a problem hiding this comment.
can be outside the for loop as well
There was a problem hiding this comment.
can be done in a separate pr as well
abdullah-cognite
requested review from
dbrattli,
a team and
finnag
and removed request for
a team
dbrattli
reviewed
Mar 7, 2025
finnag
reviewed
Mar 7, 2025
dbrattli
reviewed
Mar 7, 2025
| @@ -23,8 +23,10 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Cognite.ExtractorUtils" Version="1.29.0" /> | |||
| <PackageReference Include="Microsoft.Bcl.TimeProvider" Version="10.0.0-preview.1.25080.5" /> | |||
dbrattli
reviewed
Mar 7, 2025
| @@ -175,7 +175,8 @@ public string GetSimulatorVersion() | |||
| public Task<Dictionary<string, SimulatorValueItem>> RunSimulation( | |||
| SampleModelFilestate modelState, | |||
| SimulatorRoutineRevision routineRevision, | |||
| Dictionary<string, SimulatorValueItem> inputData | |||
| Dictionary<string, SimulatorValueItem> inputData, | |||
| CancellationToken _token | |||
There was a problem hiding this comment.
Why do we underscore the parameter name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
This package (
dotnet-simulator-utils) is used by the PROSPER connector to integrate the PROSPER simulator with CDF. Recently we were having issues with a customer where the PROSPER connector would not be able to run simulations (at random) because the connector was unable to acquire a license for starting the simulator, we came up with an approach where the connector would acquire a license at startup and keep holding on to it for a user defined period of time. We also noticed that occasionally when we shut down the PROSPER simulator, the license would still keep on being consumed unless the simulator process was killed.This PR adds
LicenseController: To help PROSPER (or any other connector) keep track of holding the license and releasing it after a timeoutProcessUtils: To help PROSPER (or any other connector) find processes belonging to the current user and terminating them. This part also caused us to modify our Github action, since the tests for this only run on Windows.This PR removes: