Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Container requires other container #1027

Merged
merged 8 commits into from
Mar 4, 2025
Merged

🐛 Container requires other container #1027

merged 8 commits into from
Mar 4, 2025

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Mar 1, 2025

Description

We fail to look-up required containers.

Bug

image

Bump

  • Patch
  • Minor
  • Skip

Changelog

Fixed

  • The neat.read.cdf() and neat.read.yaml(..., format="toolkit") no longer give a ResourceNotFoundError for containers that are required by the containers in the model and exists in CDF.

@doctrino doctrino marked this pull request as ready for review March 1, 2025 09:05
@doctrino doctrino requested a review from a team as a code owner March 1, 2025 09:05
nikokaoja
nikokaoja previously approved these changes Mar 3, 2025
@doctrino doctrino requested review from a team and BugGambit and removed request for a team March 3, 2025 08:14
Base automatically changed from load-complex-model to main March 3, 2025 10:04
@doctrino doctrino dismissed nikokaoja’s stale review March 3, 2025 10:04

The base branch was changed.

@doctrino doctrino requested a review from nikokaoja March 3, 2025 10:08
Copy link

github-actions bot commented Mar 3, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14988 12000 80% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_rules/models/dms/_validation.py 94% 🟢
TOTAL 94% 🟢

updated for commit: 3e9e88a by action🐍

@doctrino doctrino merged commit a3a4785 into main Mar 4, 2025
8 checks passed
@doctrino doctrino deleted the reference-error branch March 4, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants