Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial cdm extension via selection of concepts #1035

Merged

Conversation

nikokaoja
Copy link
Collaborator

@nikokaoja nikokaoja commented Mar 4, 2025

Description

Improved Extending Core Data Model tutorial, and made modification to the code base to assure fully functional data model in CDF. Alpha flags are renamed to Experimental flag to support tutorial.

Bump

  • Patch
  • Minor
  • Skip

Changelog

Added

  • Core Data Model transformer that produces data model version that can be extended/edited by users
  • Convenience method for extension of core data model via subsetting of concepts ..read.cdf.core_data_model in NeatSession

Changed

  • Rename alpha to experimental flags
  • Update Extending Core Data Model tutorial in documentation

Copy link

github-actions bot commented Mar 4, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
15188 12139 80% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_alpha.py 100% 🟢
cognite/neat/_constants.py 92% 🟢
cognite/neat/_rules/transformers/_converters.py 83% 🟢
cognite/neat/_session/_create.py 97% 🟢
cognite/neat/_session/_prepare.py 61% 🟢
cognite/neat/_session/_read.py 69% 🟢
cognite/neat/_session/_subset.py 39% 🟢
cognite/neat/_session/_to.py 77% 🟢
cognite/neat/_session/exceptions.py 82% 🟢
cognite/neat/_store/_rules_store.py 86% 🟢
TOTAL 79% 🟢

updated for commit: aeaa384 by action🐍

@nikokaoja nikokaoja marked this pull request as ready for review March 4, 2025 14:56
@nikokaoja nikokaoja requested a review from a team as a code owner March 4, 2025 14:56
@nikokaoja nikokaoja added the auto-merge Bulldozer auto-merge label Mar 4, 2025
Copy link
Collaborator

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few clarification, what I am most surprised by is starting with subsetting and not neat.read.

doctrino
doctrino previously approved these changes Mar 5, 2025
@doctrino doctrino enabled auto-merge (squash) March 6, 2025 13:02
@nikokaoja nikokaoja requested review from a team and simenl and removed request for larshagencognite and a team March 7, 2025 04:39
@nikokaoja
Copy link
Collaborator Author

nikokaoja commented Mar 7, 2025

Critical to be approved due to upcoming workshops in Japan (March 10) and USA (March 18) !

@simenl simenl requested review from larshagencognite and removed request for simenl March 7, 2025 12:23
@doctrino doctrino requested review from a team and finnag and removed request for a team March 7, 2025 12:58
@larshagencognite
Copy link

risk review ok - the code looks fine, but the size of this PR makes it hard to review for an outsider. Note that we will require PRs to be split up going forward.

@doctrino doctrino merged commit aab4753 into main Mar 7, 2025
8 checks passed
@doctrino doctrino deleted the update-tutorial-cdm-extension-via-selection-of-concepts branch March 7, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bulldozer auto-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants