fix(react-components): avoid fetching classic asset mappings when in …

…coredm only and recache all revisionIds when requesting the connections with views (#4946) * Avoid fetching classic asset mappings when in coredm only and recache all revisionIds when request the connecitons with views * fix the request of views and add a hook with the coreDM flag * cr changes
cognitedata · Jan 8, 2025 · 1ab3dee · 1ab3dee
1 parent 7f210db
commit 1ab3dee
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/react-components/src/components/CacheProvider/RevisionFdmNodeCache.ts b/react-components/src/components/CacheProvider/RevisionFdmNodeCache.ts
@@ -301,9 +301,9 @@ export class RevisionFdmNodeCache {
     );
 
     allConnectionsWithoutView.forEach((fdmConnectionWithNode, ind) => {
-      const connectionWithView = {
+      const connectionWithView: FdmConnectionWithNode = {
         ...fdmConnectionWithNode,
-        view: nodeInspectionResults.items[ind].inspectionResults.involvedViews[0]
+        views: [nodeInspectionResults.items[ind].inspectionResults.involvedViews[0]]
       };
 
       this.insertTreeIndexMappings(connectionWithView.cadNode.treeIndex, connectionWithView);

diff --git a/react-components/src/components/RuleBasedOutputs/RuleBasedOutputsSelector.tsx b/react-components/src/components/RuleBasedOutputs/RuleBasedOutputsSelector.tsx
@@ -115,10 +115,10 @@ export function RuleBasedOutputsSelector({
 
           const flatAssetsMappingsList = flatAssetsMappingsListPerModel.get(model) ?? [];
 
-          if (flatAssetsMappingsList.length === 0) return [];
+          if (flatAssetsMappingsList.length === 0 && fdmMappings?.length === 0) return [];
 
           const mappingsStylings = await initializeRuleBasedOutputs({
-            assetMappings: flatAssetsMappingsList ?? [],
+            assetMappings: flatAssetsMappingsList,
             fdmMappings: fdmMappings ?? [],
             contextualizedAssetNodes,
             ruleSet,

diff --git a/react-components/src/hooks/cad/useAssetMappedNodesForRevisions.ts b/react-components/src/hooks/cad/useAssetMappedNodesForRevisions.ts
@@ -5,12 +5,15 @@ import { useQuery, type UseQueryResult } from '@tanstack/react-query';
 import { type CadModelOptions } from '../../components';
 import { type ModelWithAssetMappings } from './ModelWithAssetMappings';
 import { useAssetMappingAndNode3DCache } from '../../components/CacheProvider/CacheProvider';
+import { useIsCoreDmOnly } from '../useIsCoreDmOnly';
 
 export const useAssetMappedNodesForRevisions = (
   cadModels: CadModelOptions[]
 ): UseQueryResult<ModelWithAssetMappings[]> => {
   const assetMappingAndNode3DCache = useAssetMappingAndNode3DCache();
 
+  const isCoreDmOnly = useIsCoreDmOnly();
+
   return useQuery({
     queryKey: [
       'reveal',
@@ -28,6 +31,6 @@ export const useAssetMappedNodesForRevisions = (
       return await Promise.all(fetchPromises);
     },
     staleTime: Infinity,
-    enabled: cadModels.length > 0
+    enabled: cadModels.length > 0 && !isCoreDmOnly
   });
 };
diff --git a/react-components/src/hooks/useIsCoreDmOnly.ts b/react-components/src/hooks/useIsCoreDmOnly.ts
@@ -0,0 +1,10 @@
+/*!
+ * Copyright 2025 Cognite AS
+ */
+import { useRenderTarget } from '../components';
+
+export function useIsCoreDmOnly(): boolean {
+  const renderTarget = useRenderTarget();
+  const isCoreDmOnly = renderTarget.cdfCaches.coreDmOnly;
+  return isCoreDmOnly ?? false;
+}