feat(react-components): add hotkeys P to toggle the Poi tool and Esc to remove the Poi creation - including the floating panel #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on - including the floating panel
haakonflatval-cognite
approved these changes
Nov 28, 2024
| @@ -281,8 +281,12 @@ export abstract class BaseTool extends RenderTargetCommand { | |||
| /** | |||
| * AnchorDialog | |||
| */ | |||
|
|
|||
| type CustomListener = { eventName: string; callback: (event: Event) => void }; | |||
There was a problem hiding this comment.
Strictly speaking, this should be exported, since it's part of the other exported type
Comment on lines
25
to
27
| dialogContent.customListeners.forEach((listener) => { | ||
| window.addEventListener(listener.eventName, listener.callback, true); | ||
| }); |
There was a problem hiding this comment.
Very nitpicky, but this could be a little shorter with dialogContent.customListeners?.forEach(... and removing the if-check
There was a problem hiding this comment.
ops.. ofc
Comment on lines
36
to
46
| if (dialogContent === undefined || isSomeEnabled !== true) { | ||
| return undefined; | ||
| } | ||
|
|
||
| if (renderTarget === undefined) { | ||
| return <></>; | ||
| } | ||
|
|
||
| if (activeTool === undefined) { | ||
| return <></>; | ||
| } |
There was a problem hiding this comment.
I think we can just combine all of these to one if-check? 🤔
… danpriori/hotkeys-for-pois
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Add hotkeys for Point of Interests.
P to toggle the tool and Esc to close/exit the creation
Test instructions ℹ️
Checklist ☑️