-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react-components): move caching into separate class in architecture #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonflatval-cognite
had a problem deploying
to
CI
November 28, 2024 17:01 — with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
November 28, 2024 17:06 — with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
November 28, 2024 17:08 — with
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
December 1, 2024 12:07 — with
GitHub Actions
Failure
haakonflatval-cognite
changed the title
refactor(react-components): move caching into domain object
refactor(react-components): move caching into separate class in architecture
Dec 1, 2024
haakonflatval-cognite
had a problem deploying
to
CI
December 1, 2024 13:56 — with
GitHub Actions
Failure
haakonflatval-cognite
temporarily deployed
to
CI
December 1, 2024 16:08 — with
GitHub Actions
Inactive
danpriori
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
react-components/src/hooks/pointClouds/usePointCloudAnnotationMappingForAssetId.ts
Outdated
Show resolved
Hide resolved
haakonflatval-cognite
temporarily deployed
to
CI
December 2, 2024 07:21 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Move caches from context providers and into their own domain object. This is a preliminary step to be able to use the cache's functionality for fetching data on click from within the architecture
Most of the codeline changes are putting hooks in separate files (so you don't have to read them closely, they're unchanged).
But there are a couple of other changes:
RevealContext
has been rewired to make this initialization happenHow has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️