Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-components): some poi fixes: selected poi with blue color #4913

Merged
merged 2 commits into from
Dec 1, 2024
Merged

fix(react-components): some poi fixes: selected poi with blue color #4913

merged 2 commits into from
Dec 1, 2024

Conversation

danpriori
Copy link
Contributor

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Selected poi with blue color

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@danpriori danpriori requested a review from a team as a code owner December 1, 2024 12:48
haakonflatval-cognite
haakonflatval-cognite approved these changes Dec 1, 2024
View reviewed changes
react-components/src/architecture/concrete/pointsOfInterest/color.ts
@@ -7,7 +7,7 @@ import { PointsOfInterestStatus } from './types';

export const DEFAULT_OVERLAY_COLOR = new Color('#C945DB');
export const PENDING_OVERLAY_COLOR = new Color('#33AA33');
export const SELECTED_COLOR = new Color('##6464FF');
export const SELECTED_COLOR = new Color('#5151ce');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops - seems like I pushed the previous change a bit too fast 🙈 Where did you find this new color? The previous one is the same we use for highlighting CAD, but perhaps it's a good idea to make them a little different 🤔

Copy link
Contributor Author

@danpriori danpriori Dec 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a color picker. Maybe the screenshot compression has changed the code. But yeah, I should have checked this color before 🙈

@danpriori danpriori merged commit 0221063 into master Dec 1, 2024
14 checks passed
@danpriori danpriori deleted the danpriori/poi-fixes branch December 1, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danpriori @haakonflatval-cognite