Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-components): color clicked poi instance and bump to 0.73.0 #4915

Merged
merged 21 commits into from
Dec 2, 2024
Merged

feat(react-components): color clicked poi instance and bump to 0.73.0 #4915

merged 21 commits into from
Dec 2, 2024

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Dec 1, 2024 •
edited
Loading

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

  • Implements find-instances-from-click function compatible with architecture (does not fetch FDM views)
  • Provides centralized instance styling in architecture
  • Lets PointsOfInterestTool control an instance styling related to an asset that was clicked while the tool was active

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner December 1, 2024 15:21
@haakonflatval-cognite haakonflatval-cognite marked this pull request as draft December 1, 2024 15:21
Base automatically changed from hflatval/centralize-caching to master December 2, 2024 07:24
@haakonflatval-cognite haakonflatval-cognite marked this pull request as ready for review December 2, 2024 10:01
@haakonflatval-cognite haakonflatval-cognite changed the title WIP feat(react-components): color clicked poi instance feat(react-components): color clicked poi instance Dec 2, 2024
nilscognite
nilscognite approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@nilscognite nilscognite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of unknown stuff for me here. I had a few comments

react-components/src/architecture/concrete/pointsOfInterest/PointsOfInterestTool.ts Show resolved Hide resolved
react-components/src/utilities/getInstancesFromClick.ts
import { is360ImageAnnotation } from './is360ImageAnnotation';
import { type RevealRenderTarget } from '../architecture';

export async function getInstancesFromClick(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the same folder as PointsOfInterestTool

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want this to be a general function that can be used multiple places. I think it will be easier for others to find if it's here

@haakonflatval-cognite haakonflatval-cognite changed the title feat(react-components): color clicked poi instance feat(react-components): color clicked poi instance and bump to 0.73.0 Dec 2, 2024
@haakonflatval-cognite haakonflatval-cognite merged commit e345cbf into master Dec 2, 2024
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/color-clicked-poi-instance branch December 2, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilscognite nilscognite nilscognite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonflatval-cognite @nilscognite