fix(react-components): list 360-core-dm-connected assets #4967
Conversation
Does not include Search-capabilities
haakonflatval-cognite
temporarily deployed
to
CI
GitHub Actions
Inactive
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
|
There were failures in the visual tests workflow. |
viewer/packages/data-providers/src/image-360-data-providers/cdm/queryFilters.ts
Outdated
Show resolved
Hide resolved
viewer/packages/360-images/src/collection/DefaultImage360Collection.ts
Outdated
Show resolved
Hide resolved
| @@ -153,3 +124,93 @@ function getObject3dRelation(visualizableTableName: string): QueryTableExpressio | |||
| } | |||
| }; | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/explicit-function-return-type | |||
| export function createCheck3dConnectedEquipmentQuery( | |||
There was a problem hiding this comment.
I see that we have too many properties been selected here in single query, was wondering if it could have any performance issue while fetching huge data for all resources
There was a problem hiding this comment.
Yes, it's quite a lot 😓 I'm sure it can be heavy for some queries, but in practice, I don't think there will be a huge amount of returned data. We're only looking for 3D-connections (including directly connected, indirect through reference and indirect through edge) in the different model types for a few specific input instances. I expect almost all such queries to return less than 100 results for each input instance in total
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
I swear, I could not for the life of me make the linter accept this.
haakonflatval-cognite
temporarily deployed
to
CI
GitHub Actions
Inactive
haakonflatval-cognite
temporarily deployed
to
CI
GitHub Actions
Inactive
haakonflatval-cognite
temporarily deployed
to
CI
GitHub Actions
Inactive
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
There was a problem hiding this comment.
🦄
@haakonflatval-cognite next time, please try to make smaller PRs if possible. >400 lines PRs is hard to review properly and the risk review team prioritize small PRs when we review.
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
haakonflatval-cognite
had a problem deploying
to
CI
GitHub Actions
Failure
| const deepProperties = (instance.properties?.[source.space] as Record<string, unknown>)?.[ | ||
| propertyKey | ||
| ] as Record<string, unknown>; | ||
|
|
There was a problem hiding this comment.
I'm terribly sorry for this abomination. The types of this function is inherently broken, but fixing them must be undertaken as a separate task, as it's way out of scope for this PR. I have tracked this in this JIRA issue: https://cognitedata.atlassian.net/browse/BND3D-5469
haakonflatval-cognite
requested review from
a team and
psalaberria002
and removed request for
a team
|
🦄 |
Does not include Search-capabilities
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Return coreDM-360-connected assets from the useSearch...-hook.
Not yet finished - next step is ensuring it also works with the search functionality.Should be working now 👍
Enables https://github.com/cognitedata/fusion/pull/11099
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️