Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): Add circle and cylinder measurement #4996

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nilscognite
Copy link
Contributor

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-5355

Description 📝

Add vertical cylinder and horizontal circle

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have liked some tests on this - but perhaps it's part of your ongoing test-related work?

Otherwise, LGTM 🙌

@pramod-cog pramod-cog marked this pull request as draft February 19, 2025 10:42
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 31.33803% with 195 lines in your changes missing coverage. Please review.

Project coverage is 29.90%. Comparing base (dfe17bb) to head (97814bb).
Report is 664 commits behind head on master.

Files with missing lines Patch % Lines
...cture/concrete/primitives/cylinder/CylinderView.ts 24.00% 57 Missing ⚠️
...re/concrete/primitives/cylinder/CylinderCreator.ts 18.51% 44 Missing ⚠️
...ncrete/primitives/cylinder/CylinderDomainObject.ts 39.62% 32 Missing ⚠️
...re/concrete/primitives/cylinder/CylinderDragger.ts 12.00% 22 Missing ⚠️
...hitecture/concrete/measurements/MeasurementTool.ts 14.28% 12 Missing ⚠️
...measurements/commands/SetMeasurementTypeCommand.ts 0.00% 10 Missing ⚠️
...ncrete/measurements/MeasureCylinderDomainObject.ts 72.72% 9 Missing ⚠️
...architecture/base/utilities/primitives/Cylinder.ts 40.00% 3 Missing ⚠️
...ase/utilities/primitives/getIconByPrimitiveType.ts 0.00% 2 Missing ⚠️
...tecture/concrete/primitives/box/BoxDomainObject.ts 60.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4996       +/-   ##
===========================================
- Coverage   71.10%   29.90%   -41.21%     
===========================================
  Files         378      668      +290     
  Lines       38591    54571    +15980     
  Branches     2774      593     -2181     
===========================================
- Hits        27442    16321    -11121     
- Misses      11039    37998    +26959     
- Partials      110      252      +142     
Files with missing lines Coverage Δ
...tecture/base/utilities/primitives/PrimitiveType.ts 100.00% <100.00%> (ø)
...rc/architecture/concrete/primitives/box/BoxView.ts 24.11% <ø> (ø)
...act-components/src/architecture/installToolbars.ts 100.00% <100.00%> (ø)
.../concrete/annotations/CylinderGizmoDomainObject.ts 50.00% <66.66%> (ø)
...rete/annotations/commands/AnnotationsCreateTool.ts 30.76% <50.00%> (ø)
...ase/utilities/primitives/getIconByPrimitiveType.ts 18.60% <0.00%> (ø)
...tecture/concrete/primitives/box/BoxDomainObject.ts 39.89% <60.00%> (ø)
...architecture/base/utilities/primitives/Cylinder.ts 40.20% <40.00%> (ø)
...ncrete/measurements/MeasureCylinderDomainObject.ts 72.72% <72.72%> (ø)
...measurements/commands/SetMeasurementTypeCommand.ts 48.57% <0.00%> (ø)
... and 5 more

... and 1031 files with indirect coverage changes

@nilscognite nilscognite changed the title feat(react-components): Add circle and cylinder measurment feat(react-components): Add circle and cylinder measurement Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants