T18011 JenaUtils.read support jsonld #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielrogissart-cognizone
requested review from
natan-cox-cognizone and
domivds
michielrogissart-cognizone
force-pushed
the
feat/T18011/jenautils-read-support-jsonld
branch
from
34f61f5
to
cd0509f
Compare
natan-cox-cognizone
approved these changes
Sep 6, 2023
domivds
reviewed
Sep 7, 2023
Comment on lines
257
to
260
| if("jsonld".equals(extension)) { | ||
| // .jsonld is extension for application/ld+json | ||
| return "JSONLD"; | ||
| } |
There was a problem hiding this comment.
can't we put this in a map?
michielrogissart-cognizone
force-pushed
the
feat/T18011/jenautils-read-support-jsonld
branch
from
cd0509f
to
cbb8466
Compare
domivds
reviewed
Sep 7, 2023
|
|
||
| // any other extension falls back to RDF XML | ||
| return null; | ||
| return extensionToLanguageCode.getOrDefault(extension, null); |
There was a problem hiding this comment.
just get is ok, if key is not present, null is returned - add a comment that fallback (and null) is RDF/XML
Comment on lines
245
to
254
| private static Map<String, String> getExtensionToLanguageMap() { | ||
| Map<String, String> result = new HashMap<>(); | ||
|
|
||
| result.put("nt", "N-TRIPLE"); | ||
| result.put("n3", "N3"); | ||
| result.put("ttl", "TURTLE"); | ||
| result.put("jsonld", "JSONLD"); | ||
|
|
||
| return result; | ||
| } |
There was a problem hiding this comment.
private static final Map<> in class and init in static initializer (make map synchronized)
| result.put("jsonld", "JSONLD"); | ||
|
|
||
| return result; | ||
| } |
There was a problem hiding this comment.
missing empty line after method
michielrogissart-cognizone
force-pushed
the
feat/T18011/jenautils-read-support-jsonld
branch
from
cbb8466
to
caf082c
Compare
michielrogissart-cognizone
force-pushed
the
feat/T18011/jenautils-read-support-jsonld
branch
from
caf082c
to
d12796c
Compare
domivds
approved these changes
Sep 8, 2023
| // any other extension falls back to RDF XML | ||
| return null; | ||
| // when return value is null, fall back to RDF/XML | ||
| return extensionToLanguageMap.getOrDefault(extension, null); |
There was a problem hiding this comment.
it's ok to do this as here the default return value is null
extensionToLanguageMap.get(extension)
michielrogissart-cognizone
deleted the
feat/T18011/jenautils-read-support-jsonld
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #215