Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bedrock.py #665

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Update bedrock.py #665

merged 1 commit into from
Aug 22, 2024

Conversation

billytrend-cohere
Copy link
Contributor

@billytrend-cohere billytrend-cohere commented Aug 14, 2024

Thank you for contributing to the Cohere Toolkit!

  • PR title: "area: description"

    • Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "deployment: add Azure model option"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
  • Add tests and docs: Please include testing and documentation for your changes

  • Lint and test: Run make lint and make run-tests

AI Description

This pull request updates the BedrockDeployment class in bedrock.py by removing hardcoded models from the BedrockClient initialization.

File Changes

  • src/backend/model_deployments/bedrock.py

Code Changes

  • Removes the hardcoded values for chat_model, embed_model, and generate_model from the BedrockClient initialization in the __init__ method of the BedrockDeployment class.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (f9ec818) to head (637a1f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files         238      238           
  Lines       10455    10455           
=======================================
  Hits         8061     8061           
  Misses       2394     2394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeatrixCohere BeatrixCohere added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit dbc5b7b Aug 22, 2024
6 checks passed
@BeatrixCohere BeatrixCohere deleted the billytrend-cohere-patch-3 branch August 22, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants