-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend: compass file tool fix + generate FE client #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scott-cohere
commented
Aug 14, 2024
•
edited
Loading
edited
- adds a small fix to the search/read file tools, this will allow for proper file name to show in "resources referenced:..." FE message
- removes the old (singular) file upload endpoint as we use batch upload endpoint now
- splits upload endpoints between /conversation and /agent -> also splits the schema for the request and responses
- generate the new FE client
- thank you khalil and tomeu for the corresponding FE changes
scott-cohere
requested review from
tomtobac,
abimacarmes,
knajjars,
EugeneLightsOn,
malexw,
scottmx81,
tianjing-li and
a team
as code owners
August 14, 2024 19:04
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
- Coverage 74.27% 74.15% -0.13%
==========================================
Files 253 253
Lines 10982 10925 -57
==========================================
- Hits 8157 8101 -56
+ Misses 2825 2824 -1 ☔ View full report in Codecov by Sentry. |
knajjars
reviewed
Aug 15, 2024
src/interfaces/assistants_web/src/cohere-client/generated/types.gen.ts
Outdated
Show resolved
Hide resolved
…toolkit into scott/compass-files-FE
BeatrixCohere
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.