-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend: fix is_available in gdrive tool #672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1vn
requested review from
EugeneLightsOn,
malexw,
scottmx81,
tianjing-li and
a team
as code owners
August 15, 2024 11:49
1vn
changed the title
fix is_available in gdrive tool
backend: fix is_available in gdrive tool
Aug 15, 2024
BeatrixCohere
approved these changes
Aug 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 74.60% 74.60%
=======================================
Files 256 256
Lines 11054 11054
=======================================
Hits 8247 8247
Misses 2807 2807 ☔ View full report in Codecov by Sentry. |
1vn
force-pushed
the
minor-fix-gdrive-is-available
branch
from
August 15, 2024 12:44
7eafb9a
to
39a76b7
Compare
…web (#668) Bumps [axios](https://github.com/axios/axios) from 1.6.8 to 1.7.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.8...v1.7.4) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khalil Najjar <[email protected]>
…sistants_web (#469) build(deps): bump postcss in /src/interfaces/assistants_web Bumps [postcss](https://github.com/postcss/postcss) from 7.0.39 to 8.4.39. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.39) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khalil Najjar <[email protected]>
…bot (#669) Bumps [axios](https://github.com/axios/axios) from 1.7.2 to 1.7.4. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.2...v1.7.4) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khalil Najjar <[email protected]>
#663) * feat: arrow up inside of composer will fill with the last user message * fix: take the last user message instead the first one * refactor: run format --------- Co-authored-by: Khalil Najjar <[email protected]>
1vn
force-pushed
the
minor-fix-gdrive-is-available
branch
from
August 15, 2024 12:56
39a76b7
to
dcac9bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that we're checking CLIENT_ID is None twice instead of also checking CLIENT_SECRET
AI Description
This pull request updates the
is_available
method in theGoogleDrive
class oftool.py
.Summary
The
is_available
class method now checks for the presence of bothCLIENT_ID
andCLIENT_SECRET
to determine availability, whereas previously, it only checked forCLIENT_ID
twice.Changes
is_available
class method inGoogleDrive
class to check forCLIENT_SECRET
.