Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): Add CI to check client is properly generated for coral/assistants #869

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

tianjing-li
Copy link
Collaborator

@tianjing-li tianjing-li commented Dec 5, 2024

Thank you for contributing to the Cohere Toolkit!

  • PR title: "area: description"

    • Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "deployment: add Azure model option"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
  • Add tests and docs: Please include testing and documentation for your changes

  • Lint and test: Run make lint and make run-tests

AI Description

Generating pr description

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (76e9270) to head (7940c36).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   78.96%   78.96%           
=======================================
  Files         258      258           
  Lines       10984    10984           
=======================================
  Hits         8674     8674           
  Misses       2310     2310           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianjing-li tianjing-li changed the title [WIP] chore(frontend): Add CI to check client is properly generated for coral/assistants chore(frontend): Add CI to check client is properly generated for coral/assistants Dec 5, 2024
Copy link
Collaborator

@malexw malexw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Is the plan to add a similar check to the Coral workflow once the Deployments change is merged?

@tianjing-li
Copy link
Collaborator Author

@malexw that's right

@tianjing-li tianjing-li merged commit a5892ca into main Dec 6, 2024
8 checks passed
@tianjing-li tianjing-li deleted the add-frontend-generate-check branch December 6, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants