-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add make check-config
command
#875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianjing-li
requested review from
EugeneLightsOn,
malexw,
scottmx81 and
a team
as code owners
December 10, 2024 17:26
tianjing-li
had a problem deploying
to
development
December 10, 2024 17:27 — with
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 78.11% 78.11%
=======================================
Files 259 259
Lines 11114 11114
=======================================
Hits 8682 8682
Misses 2432 2432 ☔ View full report in Codecov by Sentry. |
tianjing-li
had a problem deploying
to
development
December 10, 2024 17:43 — with
GitHub Actions
Failure
tianjing-li
had a problem deploying
to
development
December 10, 2024 18:57 — with
GitHub Actions
Failure
tianjing-li
had a problem deploying
to
development
December 10, 2024 19:00 — with
GitHub Actions
Failure
tianjing-li
temporarily deployed
to
development
December 10, 2024 19:09 — with
GitHub Actions
Inactive
EugeneLightsOn
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new make command to
check-config
Sample output:
AI Description
This PR introduces a new
check-config
command to the Makefile, which runs a Python script to check the configuration and secrets files for missing keys. The script reads the configuration and secrets files, compares them to their respective templates, and prints warnings for any missing keys.The PR also updates the
poetry.lock file to use a different version of the
onnxruntimepackage, and updates the
pyproject.toml` file to match.The following changes are made:
check-config
command is added to the Makefile, which runs a Python script to check the configuration and secrets files for missing keys.src/backend/scripts/config
directory, which reads the configuration and secrets files, compares them to their respective templates, and prints warnings for any missing keys.poetry.lock file is updated to use a different version of the
onnxruntime` package.pyproject.toml
file is updated to match the new version ofonnxruntime
.src/backend/cli
directory is renamed tosrc/backend/scripts/cli
, and thesrc/backend/scripts/config
directory is added.src/backend/tests/unit/cli/test_main.py
file is updated to import from the newsrc/backend/scripts/cli/main.py
file.