chore: Check config when running make dev
#888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianjing-li
requested review from
EugeneLightsOn,
malexw,
scottmx81 and
a team
as code owners
tianjing-li
temporarily deployed
to
development
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 77.84% 77.84%
=======================================
Files 259 259
Lines 11176 11176
=======================================
Hits 8700 8700
Misses 2476 2476 ☔ View full report in Codecov by Sentry. |
EugeneLightsOn
approved these changes
Jan 8, 2025
ezawadski
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Description
This PR introduces changes to the
Makefile, primarily focusing on thecheck-configtarget and related tasks.Summary
The
check-configtarget has been split into two separate targets:check-config-installandcheck-config. The former now handles the installation process, while the latter is responsible for running the configuration check. This separation enhances clarity and modularity in the build process.Changes
check-config-installto handle the installation process.check-configtarget to only run the configuration check.make check-configto thedevtarget, ensuring the configuration check is executed during development.