Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore: Remove yarn 9999 in package.json #892

Closed
wants to merge 3 commits into from
Closed

Conversation

tianjing-li
Copy link
Collaborator

@tianjing-li tianjing-li commented Jan 7, 2025

This prevented dependabot runs, and was not necessary. Removing yarn and pnpm versions from the package.json engines
AI Description

This pull request updates the package.json files for the src/interfaces/assistants_web and src/interfaces/coral_web directories.

Changes

  • The package.json files for both directories have been updated to use a specific version of pnpm (^9.10.0) instead of the previous generic version (9999).
  • The yarn dependency has been removed from both package.json files.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (131a1a2) to head (df1d419).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files         259      259           
  Lines       11176    11176           
=======================================
  Hits         8700     8700           
  Misses       2476     2476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EugeneLightsOn EugeneLightsOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you TJ

@tianjing-li tianjing-li changed the title chore: Remove yarn 9999 in package.json [WIP] chore: Remove yarn 9999 in package.json Jan 8, 2025
@tianjing-li
Copy link
Collaborator Author

Resolved itself now

@tianjing-li tianjing-li closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants