Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: Prioritize YAML config over .env config #916

Closed
wants to merge 1 commit into from

Conversation

tianjing-li
Copy link
Collaborator

@tianjing-li tianjing-li commented Jan 20, 2025

Thank you for contributing to the Cohere Toolkit!

  • PR title: "area: description"

    • Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "deployment: add Azure model option"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
  • Add tests and docs: Please include testing and documentation for your changes

  • Lint and test: Run make lint and make run-unit-tests

AI Description

This PR introduces a change to the settings_customise_sources function in the src/backend/config/settings.py file. The function now includes an additional dotenv_settings parameter, which is inserted between the env_settings and YamlConfigSettingsSource parameters.

Changes:

  • The dotenv_settings parameter is added to the settings_customise_sources function.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.75%. Comparing base (3b1c27f) to head (0b52b3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files         272      272           
  Lines       10638    10638           
=======================================
  Hits         8165     8165           
  Misses       2473     2473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EugeneLightsOn EugeneLightsOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one comment - I think we should add some explanation to the documentation about the priority.

@tianjing-li
Copy link
Collaborator Author

Deprioritizing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants