Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Port ethereum beacon support #104

Merged
merged 4 commits into from
Sep 20, 2024
Merged

feat: Port ethereum beacon support #104

merged 4 commits into from
Sep 20, 2024

Conversation

wangwzhou
Copy link
Contributor

@wangwzhou wangwzhou commented Sep 18, 2024 •
edited
Loading

What changed? Why?

  1. Support ethereum-beacon network

How did you test the change?

  • unit test
  • integration test
  • functional test
  • adhoc test (described below)

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 18, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wangwzhou wangwzhou marked this pull request as ready for review September 18, 2024 01:52
@wangwzhou wangwzhou requested a review from a team as a code owner September 18, 2024 01:52
@edwinchen12
Copy link
Contributor

Did we run the unit tests locally @wangwzhou ?

@wangwzhou
Copy link
Contributor Author

Did we run the unit tests locally ?

Yes, I've run make test locally, in the meanwhile, tests also run in CI step, https://github.com/coinbase/chainstorage/actions/runs/10914019957/job/30291453125?pr=104 @edwinchen12

edwinchen12
edwinchen12 previously approved these changes Sep 18, 2024
View reviewed changes
@edwinchen12 edwinchen12 self-requested a review September 18, 2024 22:22
edwinchen12
edwinchen12 previously approved these changes Sep 19, 2024
View reviewed changes
chaoyaji-cb
chaoyaji-cb previously approved these changes Sep 19, 2024
View reviewed changes
@wangwzhou wangwzhou closed this Sep 19, 2024
@wangwzhou wangwzhou reopened this Sep 19, 2024
@wangwzhou wangwzhou merged commit 57f1971 into coinbase:master Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinchen12 edwinchen12 edwinchen12 approved these changes

@chaoyaji-cb chaoyaji-cb Awaiting requested review from chaoyaji-cb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangwzhou @cb-heimdall @edwinchen12 @chaoyaji-cb