Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create dlq implement type by config #54

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat: create dlq implement type by config #54

merged 1 commit into from
Oct 27, 2023

Conversation

bestmike007
Copy link
Contributor

@bestmike007 bestmike007 commented Oct 27, 2023 •
edited
Loading

What changed? Why?

Move SQS implementation to sub package and create dlq instance according to config type. Part of #44 #60

How did you test the change?

  • GitHub Actions
  • make server

@bestmike007 bestmike007 requested a review from a team as a code owner October 27, 2023 18:37
@jiezhang jiezhang merged commit b18a24c into coinbase:master Oct 27, 2023
5 checks passed
@bestmike007 bestmike007 deleted the feat/dlq-by-config branch October 28, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiezhang jiezhang jiezhang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bestmike007 @jiezhang