Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use latest protobuf, grpc, and gomock #65

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

bestmike007
Copy link
Contributor

@bestmike007 bestmike007 commented Nov 9, 2023

What changed? Why?

  • Switch gomock to go.uber.org/mock v0.3.0
  • Use google.golang.org/protobuf v1.31.0
  • Use google.golang.org/grpc v1.59.0
  • Use protoc 4.25.0
  • Add a mock util: func MatchProto(m proto.Message) gomock.Matcher, the default gomock.AnyMatcher fail to compare proto message with a clone
  • Ensure that all mocked functions match the target signature

How did you test the change?

GitHub Actions

@bestmike007 bestmike007 requested a review from a team as a code owner November 9, 2023 06:12
go.mod Outdated Show resolved Hide resolved
internal/blockchain/client/arbitrum_test.go Show resolved Hide resolved
jiezhang
jiezhang previously approved these changes Nov 9, 2023
go.mod Show resolved Hide resolved
@jiezhang jiezhang merged commit ae3f2b7 into coinbase:master Nov 9, 2023
9 checks passed
@bestmike007 bestmike007 deleted the feat/use-latest-protobuf-grpc branch November 9, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants