feat: store-only firestore DLQ #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bestmike007 <[email protected]>
jiezhang
reviewed
Jan 22, 2024
| return &dlqFactory{params} | ||
| } | ||
|
|
||
| func New(params DLQParams) (DLQ, error) { |
There was a problem hiding this comment.
can you simply use dlq.NewNop?
There was a problem hiding this comment.
We'd better store the events in case we need it, no?
There was a problem hiding this comment.
This feature is getting deprecated. But we can merge it as is.
jiezhang
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
A firestore-based store-only DLQ for storing unexpected blocks
How did you test the change?
GitHub Actions