fix: revert change resulting in slow identity resolution #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
approved these changes
Feb 10, 2025
alessey
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR fixes logic for fetching Basenames and ENS names in
getName.In the case where the chain is Base and the user does not have a Basename, we hit an arm in the if/else where nothing is returned, allowing us to hit the case where we fallback to the ENS name.
In that case, we want to be sure that we read from mainnet. Instead, we were attempting to read from Base, which caused retries and ultimately a timeout that returned null.
This reverts the prior change here.
Notes to reviewers
How has it been tested?