Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newly added colcon_core.logging.get_effective_console_level #16

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 6, 2024

The newly provided function replaces the private implementation carried here.

This PR should be updated to include the new version constraint when colcon-core is next released, so marking draft until then.

The newly provided function replaces the private implementation carried
here.
@cottsay cottsay added the enhancement New feature or request label Jun 6, 2024
@cottsay cottsay self-assigned this Jun 6, 2024
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR need to increase the minimum colcon_core version to take this feature?

@cottsay
Copy link
Member Author

cottsay commented Jun 13, 2024

Does this PR need to increase the minimum colcon_core version to take this feature?

Yes it does:

This PR should be updated to include the new version constraint when colcon-core is next released, so marking draft until then.

@cottsay cottsay added this to the 0.1.1 milestone Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.85%. Comparing base (aa1e317) to head (0a7e5b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   86.44%   86.85%   +0.41%     
==========================================
  Files           6        6              
  Lines         177      175       -2     
  Branches       30       28       -2     
==========================================
- Hits          153      152       -1     
  Misses         22       22              
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuclearsandwich
Copy link
Contributor

This PR should be updated to include the new version constraint when colcon-core is next released, so marking draft until then.

I can read good 🤦🏼

@cottsay cottsay marked this pull request as ready for review June 24, 2024 21:11
@cottsay cottsay merged commit d9f9520 into main Jun 24, 2024
17 checks passed
@cottsay cottsay deleted the cottsay/console-log-level branch June 24, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants