-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use newly added colcon_core.logging.get_effective_console_level #16
Conversation
The newly provided function replaces the private implementation carried here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this PR need to increase the minimum colcon_core version to take this feature?
Yes it does:
|
I'd guess I should learn to use the APIs that I author...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 86.44% 86.85% +0.41%
==========================================
Files 6 6
Lines 177 175 -2
Branches 30 28 -2
==========================================
- Hits 153 152 -1
Misses 22 22
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. |
I can read good 🤦🏼 |
The newly provided function replaces the private implementation carried here.
This PR should be updated to include the new version constraint when
colcon-core
is next released, so marking draft until then.