Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packaging.version in place of pkg_resources.parse_version #133

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Sep 6, 2023

This is an API breaking change, but I don't really see a good way to avoid it.

@KazNX FYI

This is an API breaking change, but I don't really see a good way to
avoid it.
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API break mentioned here is due to the return type changing in response right? How much duck typing overlap is there between the old and new type? This is a break and so worthy of a major bump but how much impact do we anticipate downstream?

@cottsay
Copy link
Member Author

cottsay commented Sep 22, 2023

The API break mentioned here is due to the return type changing in response right?

Affirm.

How much duck typing overlap is there between the old and new type?

Probably a lot. I think maybe pkg_resources was just using a bundled version of packaging.

This is a break and so worthy of a major bump but how much impact do we anticipate downstream?

I anticipate no breakage. This function was introduced in #57 to support a specific feature and isn't used in any supported colcon packages outside of colcon-cmake itself. We're pre-1.0 here, and colcon-core should lead the 1.0 drive, so I think a minor bump will be sufficient.

@cottsay cottsay merged commit 7e09699 into master Oct 4, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/packaging-version branch October 4, 2023 15:56
@cottsay cottsay added this to the 0.2.28 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

pkg_resources is deprecated hence colcon-cmake fails to build with the latest setuptools
2 participants