Switch from pkg_resources to importlib.metadata #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fairly clean swap, but one unintended side effect I noticed is that the "extras" dependencies are now enumerated as runtime dependencies. This is probably the right behavior for a typical "extra", but isn't really right for the "test" extras we use to declare test dependencies because these packages have already been installed and therefore will never need their test dependencies again. Some refactoring in colcon-core may be able to alleviate this.
nuclearsandwich
approved these changes
Feb 16, 2024
colcon_installed_package_information/package_augmentation/python.py
Outdated
Show resolved
Hide resolved
…on.py Co-authored-by: Steven! Ragnarök <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly clean swap, but one unintended side effect I noticed is that the "extras" dependencies are now enumerated as runtime dependencies. This is probably the right behavior for a typical "extra", but isn't really right for the "test" extras we use to declare test dependencies because these packages have already been installed and therefore will never need their test dependencies again.
Some refactoring in colcon-core may be able to alleviate this.