Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pickle instead of repr/ast.literal_eval #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use pickle instead of repr/ast.literal_eval #34

wants to merge 2 commits into from

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Apr 22, 2020

This fixes a crash with objects likeSpecifierSet, e.g. when python version compatibility is specified in setup.py

@rotu rotu force-pushed the pickle branch 3 times, most recently from 3a15f37 to 7cbccfe Compare April 22, 2020 23:15
@rotu
Use pickle instead of repr/ast.literal_eval
5d8e22c 
This fixes a crash with objects like`SpecifierSet`
@rotu
Copy link
Contributor Author

rotu commented Apr 30, 2020

This is ready. To test, you can try building tox with colcon. It crashes colcon before this PR.

@dirk-thomas dirk-thomas mentioned this pull request Dec 31, 2020
Closed
@anand-bala
Copy link

Any updates with this? I am using the python_requires field, and get a SyntaxError. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rotu @anand-bala