Enable --test-result-base to be set via a colcon mixin argument
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to the main of the verb.
maspe36
commented
Sep 24, 2022
| if not os.path.exists(path): | ||
| raise argparse.ArgumentTypeError("Path '%s' does not exist" % path) | ||
| raise RuntimeError("Path '%s' does not exist" % path) |
There was a problem hiding this comment.
Changed to a RuntimeError as its a "known" error
https://github.com/colcon/colcon-core/blob/master/colcon_core/command.py#L523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the check for the existence of the
--test-result-basedirectory to the main of the verb.In essence the check originally happened when arguments were parsed, but mixin argument values are applied after an initial parse. This created a weird inconsistency where the argument value in
default.yaml(which is parsed before mixins) works, but having it in a mixin did not work.See more details #47