Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.12 install by bumping versioneer. #202

Merged
merged 3 commits into from
May 31, 2024

Conversation

J08nY
Copy link
Contributor

@J08nY J08nY commented May 30, 2024

This fixes #201.

@pep8speaks
Copy link

pep8speaks commented May 30, 2024

Hello @J08nY! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 381:80: E501 line too long (84 > 79 characters)
Line 471:80: E501 line too long (80 > 79 characters)
Line 474:80: E501 line too long (84 > 79 characters)

Line 26:80: E501 line too long (80 > 79 characters)
Line 27:80: E501 line too long (86 > 79 characters)
Line 28:80: E501 line too long (81 > 79 characters)
Line 33:80: E501 line too long (83 > 79 characters)
Line 45:80: E501 line too long (83 > 79 characters)
Line 222:80: E501 line too long (87 > 79 characters)
Line 224:80: E501 line too long (86 > 79 characters)
Line 252:80: E501 line too long (85 > 79 characters)
Line 284:80: E501 line too long (87 > 79 characters)
Line 286:80: E501 line too long (83 > 79 characters)
Line 288:80: E501 line too long (86 > 79 characters)
Line 888:80: E501 line too long (85 > 79 characters)
Line 978:80: E501 line too long (80 > 79 characters)
Line 981:80: E501 line too long (87 > 79 characters)
Line 1419:80: E501 line too long (84 > 79 characters)
Line 1620:80: E501 line too long (80 > 79 characters)
Line 1623:80: E501 line too long (84 > 79 characters)
Line 1893:80: E501 line too long (83 > 79 characters)
Line 1988:80: E501 line too long (80 > 79 characters)
Line 1989:80: E501 line too long (85 > 79 characters)
Line 2030:80: E501 line too long (84 > 79 characters)
Line 2032:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-05-30 12:04:01 UTC

@hmaarrfk
Copy link
Collaborator

Thank you for noticing this.

I'm sorry this is somewhat impossible to review from an OSS perspective.

Would you be able to:

  1. Keep the changes to the CIs.
  2. Keep the changes to the configuration files.
  3. Give me commands to run to regenerate the versioneer files.

@J08nY
Copy link
Contributor Author

J08nY commented May 30, 2024

I just did:

pip install versioneer
versioneer install

You can do the changes yourselff, I do not much care about the commits, just that it works and installs on 3.12.

Btw. you can also move from the vendored mode to build-time-dependency mode of versioneer, which will mean no autogenerated files in the repo.

@hmaarrfk
Copy link
Collaborator

Thanks for the commands, I reran then on your branch and it works as promised. thx!

@hmaarrfk hmaarrfk merged commit 96e9538 into colinoflynn:master May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails for Python 3.12
3 participants