Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuditActionExecutor: factored out case distinction into separate method. #19

Closed
wants to merge 1 commit into from

Conversation

reinhardt
Copy link
Contributor

Refs #18

The new process_action method can be overridden in custom adapters to handle other event types while still reusing the basic processing that remains in the __call__ method.

@ale-rt
Copy link
Member

ale-rt commented Aug 3, 2018

I reworked your idea in #20.
I think that #20 should be preferable because it slims down further the __call__ method and avoids inspecting the stack when it is not needed.
Let me know what you think about #20 and if it solves your issue.

@pilz
Copy link
Member

pilz commented Aug 27, 2018

I cannot fully judge it but it seems a fair approach to me. Given the fact that we are in holiday season and this fix is of high benefit for the customer (and us because it can potentially reduce our manual fixing effort a lot) I want to opt to merge #20 now so that we can improve the situation of case creation rather sooner than later.

@ale-rt
Copy link
Member

ale-rt commented Aug 30, 2018

Superseded by #20

@ale-rt ale-rt closed this Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants