Make dependencies and css_class work in fieldsets as well. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this overrides `widget.pt` from `plone.app.z3cform` for *all* forms.
Should be okay: they are currently very similar. Differences:
- We lookup `@@dependencies` and `@@css_class` views on the widget, though we now accept it when these are not found.
- We set `data-pat-inlinevalidation='{"type":"z3c.form"}'`
davisagli
reviewed
Dec 7, 2022
|
|
||
|
|
||
| PloneRenderWidget.index = ViewPageTemplateFile("widget.pt") | ||
| logger.info("Patched plone.app.z3cform.views.RenderWidget to use our widget.pt.") |
There was a problem hiding this comment.
This makes me uneasy. If a project has also customized this template using z3c.jbot, which one wins?
There was a problem hiding this comment.
It makes me uneasy too.
One way to solve this, would be to actually take over the widget template from easyform in plone.app.z3cform. Should be okay. But definitely not now, a few days before Plone 6 final. That makes me far more uneasy. ;-)
mauritsvanrees
deleted the
maurits-dependencies-and-css-class-in-fieldsets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this overrides
widget.ptfromplone.app.z3cformfor all forms. Should be okay: they are currently very similar. Differences:@@dependenciesand@@css_classviews on the widget, though we now accept it when these are not found.data-pat-inlinevalidation='{"type":"z3c.form"}'This PR is targeted at my branch for PR #387, because we may need both changes in a project. The commit specific for the current PR should be cleanly applicable on the master branch, except perhaps the changelog entry.