Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pkg_resources usage #30

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Drop pkg_resources usage #30

merged 3 commits into from
Mar 6, 2025

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Mar 3, 2025

See plone/Products.CMFPlone#4126

❓ do we really want to keep testing with python 3.8 and still being compatible with python 2? πŸ˜…

@datakurre
Copy link
Contributor

datakurre commented Mar 3, 2025

@gforcada I have time to clean this up tomorrow.

It's time to drop Python 2 support.

Also check support for the latest Robot Framework versions.

Since this is one of my pet projects, I'll also look into "latest" weird way to run matrix tests with Nix. Packaging to use pyproject. Possibly uv, etc...

@datakurre
Copy link
Contributor

@gforcada What is the oldest Robot Framework version Plone still needs?

@gforcada
Copy link
Member Author

gforcada commented Mar 3, 2025

@datakurre for Plone 6.0 it is pinned to 6.0.2

@datakurre
Copy link
Contributor

Thanks. Didn't get this ready yet, but soonish https://github.com/collective/robotsuite/actions/runs/13662862819/job/38197785795

Learned that uv supports conflicting optional dependency groups in pyproject.toml, which allows locking multiple tested versions in a single lock file.

@datakurre datakurre merged commit 015366b into master Mar 6, 2025
0 of 16 checks passed
@datakurre datakurre deleted the drop-pkg-resources-usage branch March 6, 2025 16:16
@datakurre
Copy link
Contributor

@gforcada I released 3.0.0rc1, but I have not tested it with buildout.coredev myself. Please, report, if there are issues caused by dropping setuptools and switching to pyproject.toml. And if it works, I make final release.

I must be pushed to have a Robot Framework talk at PloneConf. There has been lot of development in tooling, and also syntax has nice additions (and should have more before the conf).

https://pypi.org/project/robotsuite/3.0.0rc1/

@gforcada
Copy link
Member Author

gforcada commented Mar 6, 2025

@datakurre thanks! πŸ’―

From the top of my head, I remember (@mauritsvanrees ?) that said that a distribution without a setup.py at all is a no go for zc.buildout. So if you removed it completely, we might have a bit of problem there...

But let's create a PR on buildout.coredev to actually check it πŸ‘πŸΎ

@gforcada
Copy link
Member Author

gforcada commented Mar 6, 2025

@datakurre a talk would be great indeed!

@MrTango was looking for help/ways to integrate plain playwright python tests directly into our test suite... not sure if that's something you can help with as well πŸ˜„

@mauritsvanrees
Copy link
Member

AFAIK, having everything in pyproject.toml is fine for Buildout as long as you only install actual releases. But if you need an editable install (so a checkout with mr.developer), then Buildout currently always calls setup.py, so this file is then still required. But I see it is still there, though almost empty, so it is fine. :-)

@datakurre
Copy link
Contributor

datakurre commented Mar 7, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants