Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 50 - Use Video.js CDN instead of keep old version #52

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Conversation

rodfersou
Copy link
Member

closes #50

@rodfersou rodfersou force-pushed the issue_50 branch 3 times, most recently from 6e4083b to 50c4176 Compare April 14, 2016 18:07
@rodfersou rodfersou changed the title Issue 50 - Depend on collective.js.videojs Issue 50 - Use Video.js CDN instead of keep old version Apr 14, 2016
@rodfersou rodfersou force-pushed the issue_50 branch 2 times, most recently from da64d80 to 077cd9b Compare April 14, 2016 18:14
@hvelarde hvelarde merged commit f3446bf into master Apr 20, 2016
@hvelarde hvelarde deleted the issue_50 branch April 20, 2016 16:04
@@ -30,6 +30,7 @@
<tal:notajax tal:condition="python:not ajax_load or ajax_include_head">
<div tal:replace="structure provider:plone.htmlhead" />
<link tal:replace="structure provider:plone.htmlhead.links" />
<link href="//vjs.zencdn.net/5.8/video-js.min.css" rel="stylesheet">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hvelarde
Copy link
Member

@cleberjsantos awesome! do you want to work on that on a new branch?

@cleberjsantos
Copy link
Member

cleberjsantos commented Apr 20, 2016

@hvelarde 👍 Yes ;)

@hvelarde
Copy link
Member

@cleberjsantos I added #55 feel free to work on branch issue_55.

@cleberjsantos
Copy link
Member

@hvelarde Nice, tks.

@rodfersou
Copy link
Member Author

@rodfersou
Copy link
Member Author

I just don't know if these new attributes of <script> tag would leave some accessibility issues to us..

@cleberjsantos
Copy link
Member

@rodfersou @hvelarde Hmm, then let's test :) but I believe that not we'll have problems, see w3c (W3C Candidate Recommendation 13 November 2015) https://w3c.github.io/webappsec-subresource-integrity/

@hvelarde
Copy link
Member

I don't see any issue with accessibility; if one arises we will fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take Video.js out of this package
3 participants