Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7.2 support #484

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Add Rails 7.2 support #484

merged 11 commits into from
Aug 28, 2024

Conversation

AhmedAliIbrahim
Copy link
Contributor

@AhmedAliIbrahim AhmedAliIbrahim commented Aug 11, 2024

Adds Rails 7.2 support

@@ -18,7 +18,7 @@ Gem::Specification.new do |s|

s.required_ruby_version = '>= 2.0.0'

s.add_runtime_dependency 'activerecord', '>= 4.0.0', '< 7.2'
s.add_runtime_dependency 'activerecord', '>= 4.0.0', '< 8.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 8.0 instead of 7.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the next release will be 8.0 as I know

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to add the tests configuration for Rails 7.2 like it's done for 7.1 in 034ab03

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngrebenshikov updated!

Copy link

@ngrebenshikov ngrebenshikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link

@ngrebenshikov ngrebenshikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngrebenshikov
Copy link

@parndt , could you, please, take a look at this PR and give some advises how to move it forward?

@parndt
Copy link
Collaborator

parndt commented Aug 23, 2024

@AhmedAliIbrahim @ngrebenshikov I fixed the CI issue where it was cancelling jobs, but it seems a lot of them are failing. Thank you so much for the time out of your lives to do this work. 😄

Appraisals Outdated Show resolved Hide resolved
gemfiles/rails_7_0.gemfile Outdated Show resolved Hide resolved
@AhmedAliIbrahim
Copy link
Contributor Author

AhmedAliIbrahim commented Aug 28, 2024

@AhmedAliIbrahim @ngrebenshikov I fixed the CI issue where it was cancelling jobs, but it seems a lot of them are failing. Thank you so much for the time out of your lives to do this work. 😄

I think all has been sorted out, could you please try checks again @ngrebenshikov @parndt @nickgal

@parndt
Copy link
Collaborator

parndt commented Aug 28, 2024

Brilliant, thank you @AhmedAliIbrahim

@parndt parndt merged commit 11f3cac into collectiveidea:master Aug 28, 2024
64 checks passed
@tnir tnir mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants