-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 7.2 support #484
Conversation
@@ -18,7 +18,7 @@ Gem::Specification.new do |s| | |||
|
|||
s.required_ruby_version = '>= 2.0.0' | |||
|
|||
s.add_runtime_dependency 'activerecord', '>= 4.0.0', '< 7.2' | |||
s.add_runtime_dependency 'activerecord', '>= 4.0.0', '< 8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 8.0 instead of 7.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the next release will be 8.0 as I know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to add the tests configuration for Rails 7.2 like it's done for 7.1 in 034ab03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngrebenshikov updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@parndt , could you, please, take a look at this PR and give some advises how to move it forward? |
@AhmedAliIbrahim @ngrebenshikov I fixed the CI issue where it was cancelling jobs, but it seems a lot of them are failing. Thank you so much for the time out of your lives to do this work. 😄 |
I think all has been sorted out, could you please try checks again @ngrebenshikov @parndt @nickgal |
Brilliant, thank you @AhmedAliIbrahim |
Adds Rails 7.2 support