Ignore future jobs in jobs:check.
#1159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are scheduled jobs in the future, they should not be included in the `jobs:check`, which is intended to look for jobs that *should* be processed but have not yet been processed.
albus522
reviewed
Sep 28, 2022
| @@ -30,7 +30,7 @@ | |||
| task :check, [:max_age] => :environment do |_, args| | |||
| args.with_defaults(:max_age => 300) | |||
|
|
|||
| unprocessed_jobs = Delayed::Job.where('attempts = 0 AND created_at < ?', Time.now - args[:max_age].to_i).count | |||
| unprocessed_jobs = Delayed::Job.where('attempts = 0 AND created_at < ? AND run_at <= ?', Time.now - args[:max_age].to_i, Time.now).count | |||
There was a problem hiding this comment.
Conceptually I think the max age applies to both times. Probably:
Suggested change
| unprocessed_jobs = Delayed::Job.where('attempts = 0 AND created_at < ? AND run_at <= ?', Time.now - args[:max_age].to_i, Time.now).count | |
| unprocessed_jobs = Delayed::Job.where('attempts = 0 AND created_at < :time AND run_at < :time', time: args[:max_age].to_i.seconds.ago).count |
And it is possibly better to replace created_at with run_at instead of querying both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are scheduled jobs in the future, they should not be included in the
jobs:check, which is intended to look for jobs that should be processed but have not yet been processed.