Move ActiveJob adapter to delayed_job
#1219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements adapter for `ActiveJob` inside the gem. This adapter is defined only if rails version is >=8, for earlier rails versions adapter is definied inside the Rails itself
dixpac
force-pushed
the
dix/add_active_job_adapter
branch
from
acf1951
to
8fd6420
Compare
dixpac
force-pushed
the
dix/add_active_job_adapter
branch
from
8fd6420
to
41f2b77
Compare
|
@albus522 I've moved adapter from Rails and added the tests. Let me know what do you think about this approach |
albus522
reviewed
Nov 8, 2024
| module ActiveJob | ||
| module QueueAdapters | ||
| # Explicitly remove the implementation existing in older rails'. | ||
| remove_const(:DelayedJobAdapter) if defined?(:DelayedJobAdapter) |
There was a problem hiding this comment.
Since the adapter signature has changed over time, I think this file needs to be the fallback for when it is not present in ActiveJob.
Earlopain
reviewed
Nov 11, 2024
| module ActiveJob | ||
| module QueueAdapters | ||
| # Explicitly remove the implementation existing in older rails'. | ||
| remove_const(:DelayedJobAdapter) if defined?(:DelayedJobAdapter) |
There was a problem hiding this comment.
defined?(:DelayedJobAdapter) will always be true since a symbol is passed in.
Suggested change
| remove_const(:DelayedJobAdapter) if defined?(:DelayedJobAdapter) | |
| remove_const(:DelayedJobAdapter) if const_defined?(:DelayedJobAdapter) |
albus522
reviewed
Nov 11, 2024
| @@ -1,5 +1,6 @@ | |||
| require 'delayed_job' | |||
| require 'rails' | |||
| require 'active_job/queue_adapters/delayed_job_adapter' | |||
There was a problem hiding this comment.
This should probably be in lib/delayed_job.rb using a similar ActiveSupport.on_load pattern as action mailer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements adapter for
ActiveJobinside the gem. This adapter is defined only if rails version is >=8, for earlier rails versions adapter is defined inside the Rails itself.I'm not supper familiar with delayed_job internals, this is just a draft if you are interested in doing this I can finish the work on this PR.
This is connected to the discussion here rails/rails#52929
❤️