fix the bug for threshold update #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lected in the structure
ahojnnes
reviewed
Dec 13, 2024
| @@ -19,9 +19,13 @@ struct BundleAdjusterOptions : public OptimizationBaseOptions { | |||
| // Constrain the minimum number of views per track | |||
| int min_num_view_per_track = 3; | |||
|
|
|||
| void UpdateThreshold() { | |||
There was a problem hiding this comment.
Instead of this fix, I suggest the following:
struct BundleAdjusterOptions {
double thres_loss_function = 1;
std::shared_ptr<ceres::LossFunction> CreateLossFunction() {
return std::make_shared<ceres::HuberLoss>(thres_loss_function);
}
};
Since you explicitly have to call CreateLossFunction(), it is harder to accidentally forget calling the UpdateThreshold().
|
The proposal was to return the shared pointer and not assign it. In the respective BA and GO you would then call this method to create the loss function (always with the latest threshold). |
ahojnnes
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the bug that the update of threshold from command line is not reflected in the structure