Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CALL_ORIGINAL_FUNCTION_WITH_PARAMS #14

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Fix CALL_ORIGINAL_FUNCTION_WITH_PARAMS #14

merged 5 commits into from
Sep 19, 2024

Conversation

zeriyoshi
Copy link
Contributor

Closes: #13

Thanks: @t-matsuno-777

@github-actions GitHub Actions
Copy link

Code Metrics Report

main (0b9098a) #14 (e655f17) +/-
Coverage 83.2% 84.1% +0.9%
Details 
  |           | main (0b9098a) | #14 (e655f17) |  +/-  |
  |-----------|----------------|---------------|-------|
+ | Coverage  |          83.2% |         84.1% | +0.9% |
  |   Files   |              3 |             3 |     0 |
  |   Lines   |            489 |           479 |   -10 |
- |   Covered |            407 |           403 |    -4 |

Code coverage of files in pull request scope (82.7% → 83.8%)

Files Coverage +/-
ext/hook.c 83.8% +1.1%

Reported by octocov

t-matsuno-777
t-matsuno-777 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@t-matsuno-777 t-matsuno-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@zeriyoshi zeriyoshi merged commit df5f566 into main Sep 19, 2024
39 checks passed
@zeriyoshi zeriyoshi deleted the fix_original branch September 19, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-matsuno-777 t-matsuno-777 t-matsuno-777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CALL_ORIGINAL_FUNCTION_WITH_PARAMS removes the hook state
2 participants
@zeriyoshi @t-matsuno-777