Fix jzczhz check for achromatic colors #629
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
ε
(0.00001) calculated forjzczhz
is to low for achromatic colors. The highestaz
orbz
value for an achromatic color is-0.00023625807422922307
for color(rec2100-pq 1 1 1).The
ColorSpace
class has been modified to allow settingε
when constructing aColorSpace
and theε
forjzczhz
has been set to0.0002363
.This new
ε
ensures that all achromatic colors up to the brightest white inreq2100-pq
have a null hue when converted tojzczhz
.However, with the new
ε
there are some non-achromatic colors near black inrec2100-pq
that will be considered to be achromatic when converted tojzczhz
. I think this is ok but I wanted to point them out.I rounded the
ε
, I can change it to the exact number if that's a more appropriate value.