Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI jobs for draft PRs to contributor's personal forks of Mill #3543

Draft
wants to merge 135 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
135 commits
Select commit Hold shift + click to select a range
aaa742c
.
lihaoyi Sep 12, 2024
f525f72
.
lihaoyi Sep 12, 2024
237cc18
.
lihaoyi Sep 12, 2024
51275ec
.
lihaoyi Sep 12, 2024
f4b27f6
.
lihaoyi Sep 12, 2024
d48aadb
.
lihaoyi Sep 12, 2024
ef6f54f
.
lihaoyi Sep 12, 2024
7105390
.
lihaoyi Sep 12, 2024
3969d75
.
lihaoyi Sep 12, 2024
d0ca1a9
.
lihaoyi Sep 12, 2024
c1c7026
.
lihaoyi Sep 12, 2024
2163a6d
.
lihaoyi Sep 12, 2024
3189106
.
lihaoyi Sep 12, 2024
64801f5
.
lihaoyi Sep 12, 2024
5e0cf5b
.
lihaoyi Sep 12, 2024
e9a9f3c
.
lihaoyi Sep 12, 2024
271fc39
.
lihaoyi Sep 12, 2024
222dbc4
.
lihaoyi Sep 12, 2024
0aed111
.
lihaoyi Sep 12, 2024
9665af9
Merge branch 'main' into test-non-draft
lihaoyi Sep 13, 2024
c371991
.
lihaoyi Sep 13, 2024
1d860d1
.
lihaoyi Sep 13, 2024
d42965e
Merge branch 'test-non-draft' into test-non-draft-test
lihaoyi Sep 13, 2024
aa75cc1
.
lihaoyi Sep 13, 2024
e7bda40
.
lihaoyi Sep 13, 2024
e46fa8a
Merge branch 'test-non-draft' into test-non-draft-test
lihaoyi Sep 13, 2024
22da890
.
lihaoyi Sep 13, 2024
2b11c76
.
lihaoyi Sep 13, 2024
247cc90
.
lihaoyi Sep 13, 2024
97c0c9b
Merge branch 'test-non-draft' into test-non-draft-test
lihaoyi Sep 13, 2024
4d718ee
.
lihaoyi Sep 13, 2024
45b7f19
.
lihaoyi Sep 13, 2024
29f8d9c
Merge branch 'test-non-draft-test' into test-non-draft
lihaoyi Sep 13, 2024
9ced8e6
.
lihaoyi Sep 13, 2024
c0e564e
.
lihaoyi Sep 13, 2024
555f655
.
lihaoyi Sep 13, 2024
1aa7718
.
lihaoyi Sep 13, 2024
135ac3a
.
lihaoyi Sep 13, 2024
944aba2
.
lihaoyi Sep 13, 2024
cbcec45
.
lihaoyi Sep 13, 2024
b512f13
.
lihaoyi Sep 13, 2024
5b444fd
.
lihaoyi Sep 13, 2024
75dcf27
.
lihaoyi Sep 13, 2024
9611bf5
.
lihaoyi Sep 13, 2024
e823a12
.
lihaoyi Sep 13, 2024
0cdc363
.
lihaoyi Sep 13, 2024
92b9180
.
lihaoyi Sep 13, 2024
07b887e
.
lihaoyi Sep 13, 2024
72711a1
.
lihaoyi Sep 13, 2024
628675a
.
lihaoyi Sep 13, 2024
950d9e4
.
lihaoyi Sep 13, 2024
5908906
.
lihaoyi Sep 13, 2024
81275e7
.
lihaoyi Sep 13, 2024
c5c7951
.
lihaoyi Sep 13, 2024
d4d1d6d
.
lihaoyi Sep 13, 2024
747efc4
.
lihaoyi Sep 13, 2024
a8d2b85
.
lihaoyi Sep 13, 2024
aa9a86b
.
lihaoyi Sep 13, 2024
efd189f
.
lihaoyi Sep 13, 2024
0fe0373
.
lihaoyi Sep 13, 2024
25374c9
.
lihaoyi Sep 13, 2024
aaa10b8
.
lihaoyi Sep 13, 2024
fa41dc5
.
lihaoyi Sep 13, 2024
aba7ec3
.
lihaoyi Sep 13, 2024
c1a2081
.
lihaoyi Sep 13, 2024
8fcdc17
.
lihaoyi Sep 13, 2024
d71d521
.
lihaoyi Sep 13, 2024
d71c97e
.
lihaoyi Sep 13, 2024
d413632
.
lihaoyi Sep 13, 2024
4484ebf
.
lihaoyi Sep 13, 2024
153f273
.
lihaoyi Sep 13, 2024
a14817e
.
lihaoyi Sep 13, 2024
ba3a4b6
.
lihaoyi Sep 13, 2024
f1bf9fd
.
lihaoyi Sep 13, 2024
d4dc387
.
lihaoyi Sep 13, 2024
5bbc493
.
lihaoyi Sep 13, 2024
389f55a
.
lihaoyi Sep 13, 2024
b0358f2
.
lihaoyi Sep 13, 2024
9553451
.
lihaoyi Sep 13, 2024
179f763
.
lihaoyi Sep 13, 2024
b79cb95
.
lihaoyi Sep 13, 2024
9854ef7
.
lihaoyi Sep 13, 2024
52b6b5b
.
lihaoyi Sep 13, 2024
8d6f879
.
lihaoyi Sep 13, 2024
fa68b79
.
lihaoyi Sep 13, 2024
35ab8e3
.
lihaoyi Sep 13, 2024
a4de0ea
.
lihaoyi Sep 13, 2024
3c9f8b5
.
lihaoyi Sep 13, 2024
d2af036
.
lihaoyi Sep 13, 2024
fdf1f98
.
lihaoyi Sep 13, 2024
76c4d56
.
lihaoyi Sep 13, 2024
1c36a22
.
lihaoyi Sep 13, 2024
e1c8e8e
.
lihaoyi Sep 13, 2024
09ff98b
.
lihaoyi Sep 13, 2024
36a6769
.
lihaoyi Sep 13, 2024
7637df1
.
lihaoyi Sep 13, 2024
d4aa988
.
lihaoyi Sep 13, 2024
a2eec79
.
lihaoyi Sep 13, 2024
7a535ce
.
lihaoyi Sep 13, 2024
dce0438
.
lihaoyi Sep 13, 2024
84507a5
.
lihaoyi Sep 13, 2024
c88ca37
.
lihaoyi Sep 13, 2024
a21d0ab
.
lihaoyi Sep 13, 2024
575b43f
.
lihaoyi Sep 13, 2024
2ff27cd
.
lihaoyi Sep 13, 2024
9720477
.
lihaoyi Sep 13, 2024
12e835c
.
lihaoyi Sep 13, 2024
a84d590
.
lihaoyi Sep 13, 2024
9866a44
.
lihaoyi Sep 13, 2024
1c46120
.
lihaoyi Sep 13, 2024
408e312
.
lihaoyi Sep 13, 2024
bf94983
.
lihaoyi Sep 13, 2024
6ecef18
.
lihaoyi Sep 13, 2024
b1b978a
.
lihaoyi Sep 13, 2024
49306e1
.
lihaoyi Sep 13, 2024
7bd2504
.
lihaoyi Sep 13, 2024
c94eb48
.
lihaoyi Sep 13, 2024
da71954
.
lihaoyi Sep 13, 2024
eab25d0
.
lihaoyi Sep 13, 2024
a676bc2
.
lihaoyi Sep 13, 2024
46f0fdb
.
lihaoyi Sep 13, 2024
bcd3655
.
lihaoyi Sep 13, 2024
3c8efa6
.
lihaoyi Sep 13, 2024
e2891af
.
lihaoyi Sep 13, 2024
bd801e3
.
lihaoyi Sep 13, 2024
9cb9e7f
.
lihaoyi Sep 13, 2024
aa2f4a1
.
lihaoyi Sep 13, 2024
eea45e6
.
lihaoyi Sep 13, 2024
ed1dba9
.
lihaoyi Sep 13, 2024
fbba493
.
lihaoyi Sep 13, 2024
50fb8e4
.
lihaoyi Sep 13, 2024
d820fe4
.
lihaoyi Sep 13, 2024
8910d3e
.
lihaoyi Sep 13, 2024
2bdbf24
.
lihaoyi Sep 13, 2024
230e40a
.
lihaoyi Sep 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ Please don't open issues for questions, but ask in our Discussions forum at http

Mill installations via `coursier` or `cs` are unsupported.

Please open all PRs as drafts to avoid being bottlenecked by Mill CI, and only
convert to ready for review once CI on your own fork is green. There will be a
PR status check linking your fork's commit/CI history for convenient viewing
34 changes: 34 additions & 0 deletions .github/workflows/draft-ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Draft CI

permissions: write-all
on:
pull_request_target:
types:
- opened
- reopened
- synchronize
- ready_for_review

jobs:
run:
runs-on: ubuntu-latest
permissions: write-all
steps:
- name: Debug Echos
run: |
echo ${{ github.event.action }}
echo ${{ github.event.action == 'ready_for_review' }}
echo "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}"
- name: Create status
run: |
curl --request POST \
--url ${{ github.event.pull_request.statuses_url }} \
--header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \
--header 'content-type: application/json' \
--data '{
"state": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'pending' || 'success'}}",
"context": "Draft CI / link",
"target_url": ${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && format('"{0}/commits/{1}"', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref) || 'null'}},
"description": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'use CI on your repo fork (link on right) until this PR is ready for review' || 'PR is ready for review, running CI in Mill repo'}}"
}' \
--fail-with-body
6 changes: 0 additions & 6 deletions .github/workflows/publish-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ on:
- '**'
workflow_dispatch:

# cancel older runs of a pull request;
# this will not cancel anything for normal git pushes
concurrency:
group: cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
publish-sonatype:
# when in master repo, publish all tags and manual runs on main
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,33 @@ name: Run Tests

on:
push:
branches:
- main
pull_request:
types:
- opened
- reopened
- synchronize
- ready_for_review
workflow_dispatch:

# cancel older runs of a pull request;
# this will not cancel anything for normal git pushes
concurrency:
group: cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref || github.run_id }}
group: cancel-old-pr-runs-${{ github.workflow }}-${{ github.ref_name }}
cancel-in-progress: true

jobs:
# Jobs are listed in rough order of priority: if multiple jobs fail, the first job
# in the list should be the one that's most worth looking into
build-linux:
if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false)
uses: ./.github/workflows/run-mill-action.yml
with:
java-version: '11'
millargs: __.compile
populate_cache: true

build-windows:
if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false)
uses: ./.github/workflows/run-mill-action.yml
with:
os: windows-latest
Expand All @@ -41,6 +46,7 @@ jobs:
populate_cache: true

test-docs:
if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down