Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Clean up Jvm.scala #3775

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Oct 20, 2024

Fixes #3772.

Most of the various spawning helpers should be consolidated into four: {call,spawn}{Subprocess,Classloader}.

The Subprocess method signatures should roughly follow the OS-Lib equivalents, with minimal tweaks to accommodate JVM-specific use cases (e.g. main methods, classpaths)

The Classloader methods should mostly just take a classpath and give you a classloader to work with

The new Thread("subprocess-shutdown") logic probably should be pushed upstream com-lihaoyi/os-lib#324

@lihaoyi lihaoyi marked this pull request as draft October 20, 2024 12:48
lihaoyi added a commit that referenced this pull request Oct 21, 2024
Fixes #3794

It's still pretty messy, but i'm just documenting the existing APIs that
already exist, and at least it provides a paved path for people to get
_something_ working. Cleaning them up can come separately in
#3775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up Jvm.* subprocess/inprocess APIs (500USD Bounty)
1 participant