Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate corrupt routes for testing #39

Open
adeebshihadeh opened this issue Jun 25, 2024 · 1 comment · May be fixed by #43
Open

Generate corrupt routes for testing #39

adeebshihadeh opened this issue Jun 25, 2024 · 1 comment · May be fixed by #43
Labels
CI / testing unit tests, CI, etc. enhancement New feature or request
Milestone

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jun 25, 2024

Most routes are good, but connect needs to deal with routes that are corrupt, malformed, or otherwise missing information (sometimes for valid reasons). The goal of this bounty is to make testing all those cases easy by generating the bad routes.

The deliverable is a script that takes an input route and outputs carefully corrupted routes in the same format as openpilot's logger (then we can easily upload them). Requirements:

  • default route is one of the routes on the demo account
  • should verify that the input route is actually good and doesn't contain any of the corruptions the script will introduce (starts at segment 0, no missing qlogs/qcams, etc.)
  • cases
    • no date/time
    • GPS missing
    • qlog missing
    • qcam missing
    • tnumbnail missing
    • segment too long (>60s)
@sshane
Copy link

sshane commented Jun 25, 2024

For example with current connect, if a few qcams are missing at the start it never shows the rest!

@vishalkrishnads vishalkrishnads linked a pull request Jul 1, 2024 that will close this issue
@adeebshihadeh adeebshihadeh added the CI / testing unit tests, CI, etc. label Jul 11, 2024
@adeebshihadeh adeebshihadeh added this to the 1.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI / testing unit tests, CI, etc. enhancement New feature or request
Projects
Status: Open
Development

Successfully merging a pull request may close this issue.

2 participants