Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove segment_start_times and friends #53

Closed
adeebshihadeh opened this issue Jul 5, 2024 · 1 comment · Fixed by #77
Closed

Remove segment_start_times and friends #53

adeebshihadeh opened this issue Jul 5, 2024 · 1 comment · Fixed by #77
Labels
bounty cleanup
Milestone
1.0

Comments

@adeebshihadeh
Copy link
Contributor

Same as commaai/connect#536, though we should try to avoid having to use assumed timings
@adeebshihadeh adeebshihadeh added the enhancement New feature or request label Jul 5, 2024
@adeebshihadeh adeebshihadeh changed the title Remove segment_start_times and friens Remove segment_start_times and friends Jul 5, 2024
@adeebshihadeh adeebshihadeh added cleanup bounty and removed enhancement New feature or request labels Jul 11, 2024
@adeebshihadeh adeebshihadeh added this to the 1.0 milestone Jul 11, 2024
@adeebshihadeh adeebshihadeh mentioned this issue Jul 11, 2024
Open
@trentrand trentrand mentioned this issue Jul 14, 2024
Merged
@trentrand
Copy link
Contributor

@adeebshihadeh, PR #77 resolves this issue

@github-project-automation github-project-automation bot moved this from Open to Done in openpilot bounties Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty cleanup
Projects
openpilot bounties
Status: Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Deprecate use of RouteSegments segment times fields trentrand/new-connect
2 participants
@trentrand @adeebshihadeh