Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic on non-yaml files #206

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

taigrr
Copy link
Contributor

@taigrr taigrr commented Nov 2, 2023

Fixes #131

Recover from a panic when a non-yaml file is encountered, instead of an ugly crash.

relates to #205 , but instead of ignoring regular files, it prints the errors out

Checklist

  • Added unit / integration tests for windows, macOS and Linux?
  • Added a changelog entry in CHANGELOG.md?
  • Updated the documentation (README.md, docs)?
  • Does your change work on Linux, Windows and macOS?

@dylanhitt
Copy link
Member

dylanhitt commented Nov 2, 2023

Hey @taigrr thanks for the contributions.

We originally thought about this: you can see more info here #131 for more information.

Currently the expectation is that you create a directory just with valid test files to avoid a panic. In order to avoid your problem we'd like to use a dedicated file name pattern that can be configurable.

If you'd like to take a crack at this you can. I don't have the time to implement features on this repo at the moment but do have time to review.

@taigrr
Copy link
Contributor Author

taigrr commented Nov 2, 2023

Yes, I read through #131 before submitting this pr, however that is a breaking change and this should not be so I wanted to submit this first.

Requiring a consistent extension may not be suitable for all needs, this just stops a panic and does not change any other behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define a specified test file naming convention - *.test.yaml
2 participants