Feature/multi language commitizen #1328
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay informations this is just a first version that is not yet efficient and must be implemented to be more efficient
egstion des differnts porbleme, il faut encore gerer les tests
corrcet the part of code that do not matched
J ai corrige le format de cz afin d y introduire le langage BREAKING CHANGE:
test to be sure that all the case are looked. The language option give the oppotunity to choose on wich language you want to display infomation during the commit
Vlor999
commented
Jan 26, 2025
There was a problem hiding this comment.
I think that you should review : https://github.com/commitizen-tools/commitizen/pull/1328/files. This is the last version and I think that it must work perfectly.
|
Got it. In that case, I'll close this one |
|
opps, close the wrong one |
Lee-W
requested changes
Jan 30, 2025
| @@ -0,0 +1,151 @@ | |||
| prefix_en=Select the type of change you are committing | |||
There was a problem hiding this comment.
I think we should have one file per language
| @@ -47,6 +47,7 @@ repos: | |||
| args: [ "--write-changes" ] | |||
| additional_dependencies: | |||
| - tomli | |||
| exclude: "commitizen/cz/conventional_commits/\\.cache_multilanguage\\.txt" | |||
| @@ -41,69 +44,99 @@ class ConventionalCommitsCz(BaseCommitizen): | |||
| changelog_pattern = defaults.bump_pattern | |||
|
|
|||
| def questions(self) -> Questions: | |||
| language = self.language | |||
| print(language) | |||
| @@ -0,0 +1,69 @@ | |||
| import os | |||
|
|
|||
| # mypy: ignore-errors | |||
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-modification
pr-status: wait-for-review
labels
|
As there're many changes needed, convert it to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I said previously I made mistakes with the .github that I removed by mistake. I think that now the feature may work perfectly, I hope so in fact. If there is somme issues, please say it to me. You can easily add new languages but the most common languages are here.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
I think that this feature is a way to make this extension a way most powerful and more useful for everyone.
Steps to Test This Pull Request
poetry installpoetry shellgit add .python3.X commitizen/__main__.py -language fr commitherefris just an example you can put any format.Xmust be changed with the version you are using.czin it is in production :cz -language fr commitAdditional context
It must be good for the main part