Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert upload to kotlin (part 3) #6104

Merged
merged 9 commits into from
Jan 13, 2025

Conversation

psh
Copy link
Collaborator

@psh psh commented Jan 5, 2025

Parent issue: #5928
Fixes: #6014

This should be the last of the upload package converted.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to upload a picture I get "File not found. Please try another file."

Any idea what might be the issue?

screen-20250108-135513.mp4

@psh psh force-pushed the psh/convert-upload-to-kotlin-III branch from 234bd52 to b9c2d79 Compare January 11, 2025 03:30
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I uploaded many file with this branch today, and observed a few strange things (one crash, #6123, #6125) but I guess these exist in main branch too.

@nicolas-raoul nicolas-raoul merged commit 0e73551 into commons-app:main Jan 13, 2025
1 check passed
@psh psh deleted the psh/convert-upload-to-kotlin-III branch January 15, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate upload package to kotlin
2 participants