-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSPT-228: Move test to communities domain name #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have a couple Qs:
- Why are we adding this
alias
thing - is it just for backwards compatibility? - FAB's UAT environment points to Form Designer's Test environment (because Form Designer has never been deployed to UAT), so if we are changing Form Designer's domain name in Test as part of this suite of changes, we should update this too (line 115 in manifest.yml)
Yes, this is a slightly janky workaround. Since all the DNS for the new and old domain names is pointing to the same CloudFront distribution, we need to keep these aliases, so that we can redirect in future from the old to new URLs i.e. when this function is enabled: communitiesuk/funding-service-design-workflows#266 If we remove them they'll be removed from the CloudFront distribution aliases and therefore not resolve at all. |
Good spot, have updated in 1438641 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Change description
Config changes to move test to communities domain name
How to test
After deployment service should be available on the test.communities.gov.uk domain name
Screenshots of UI changes (if applicable)