Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSPT-228: Move test to communities domain name #315

Merged
merged 3 commits into from
Mar 7, 2025
Merged

FSPT-228: Move test to communities domain name #315

merged 3 commits into from
Mar 7, 2025

Conversation

gidsg
Copy link
Contributor

@gidsg gidsg commented Mar 5, 2025

Change description

Config changes to move test to communities domain name

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

After deployment service should be available on the test.communities.gov.uk domain name

Screenshots of UI changes (if applicable)

Copy link
Contributor

@nuwan-samarasinghe nuwan-samarasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wjrm500 wjrm500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have a couple Qs:

  • Why are we adding this alias thing - is it just for backwards compatibility?
  • FAB's UAT environment points to Form Designer's Test environment (because Form Designer has never been deployed to UAT), so if we are changing Form Designer's domain name in Test as part of this suite of changes, we should update this too (line 115 in manifest.yml)

@gidsg
Copy link
Contributor Author

gidsg commented Mar 6, 2025

@wjrm500

Why are we adding this alias thing - is it just for backwards compatibility?

Yes, this is a slightly janky workaround. Since all the DNS for the new and old domain names is pointing to the same CloudFront distribution, we need to keep these aliases, so that we can redirect in future from the old to new URLs i.e. when this function is enabled: communitiesuk/funding-service-design-workflows#266

If we remove them they'll be removed from the CloudFront distribution aliases and therefore not resolve at all.

@gidsg
Copy link
Contributor Author

gidsg commented Mar 6, 2025

@wjrm500

FAB's UAT environment points to Form Designer's Test environment (because Form Designer has never been deployed to UAT), so if we are changing Form Designer's domain name in Test as part of this suite of changes, we should update this too (line 115 in manifest.yml)

Good spot, have updated in 1438641

Copy link
Contributor

@Tiny49 Tiny49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gidsg gidsg enabled auto-merge (rebase) March 7, 2025 10:49
Copy link

sonarqubecloud bot commented Mar 7, 2025

@gidsg gidsg merged commit aa2c68c into main Mar 7, 2025
10 checks passed
@gidsg gidsg deleted the fspt-228-test branch March 7, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants