Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/viewer-context-detection #1237

Merged

Conversation

ZacZhangzhuo
Copy link
Contributor

@ZacZhangzhuo ZacZhangzhuo commented Dec 22, 2023

What type of change is this?

  • Added viewerinstance in compas.scene.Scene to support viewers context detection.
  • Some import sorting.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I have added necessary documentation (if appropriate)

In the viewer, checks can be run like:

from compas.scene.context import _detect_current_context
from compas_viewer import Viewer

viewer = Viewer()
print(_detect_current_context())

This PR is associtaed to compas-dev/compas_viewer#12 @tomvanmele @Licini

@Licini
Copy link
Contributor

Licini commented Jan 3, 2024

@ZacZhangzhuo linter error

@ZacZhangzhuo
Copy link
Contributor Author

This one should be great @Licini

CHANGELOG.md Outdated
@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Unreleased

### Added

* Added `viewerinstance ` in `compas.scene.Scene` to support viewers context detection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some superfluous spaces here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Licini Licini merged commit 7b138a6 into compas-dev:main Jan 3, 2024
13 checks passed
@ZacZhangzhuo ZacZhangzhuo deleted the feature/viewer-context-detection branch January 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants